Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] dart2js test and builder configuration changes #51686

Closed
nshahan opened this issue Mar 9, 2023 · 5 comments
Closed

[CP] dart2js test and builder configuration changes #51686

nshahan opened this issue Mar 9, 2023 · 5 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
cherry-pick-approved Label for approved cherrypick request merge-to-stable

Comments

@nshahan
Copy link
Contributor

nshahan commented Mar 9, 2023

Commit(s) to merge

d77e22a

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/287903

Issue Description

We updated the configurations for running dart2js test builders in the SDK repo. There are accompanying changes in the infrastructure but that config is outside of the SDK repo and is the same across main, beta, and stable branches.

What is the fix

Changes to the dart2js test and builder configurations that work with the infrastructure changes.

Why cherry-pick

Allows dart2js test builders to run on the stable branch. Otherwise they will fail on CQ/CI.

Risk

low

Issue link(s)

#51481

Extra Info

The stable branch requires cherry picking 4 changes:
https://dart-review.googlesource.com/c/sdk/+/287903
https://dart-review.googlesource.com/c/sdk/+/287902
https://dart-review.googlesource.com/c/sdk/+/287901
https://dart-review.googlesource.com/c/sdk/+/287900
@nshahan nshahan added the cherry-pick-review Issue that need cherry pick triage to approve label Mar 9, 2023
@itsjustkevin
Copy link
Contributor

itsjustkevin commented Mar 9, 2023 •
edited
Loading

@athomas and @sigmundch again for approval.

Note: Approval here will constitute approval for the beta branch cherry-pick also.

@sigmundch
Copy link
Member

LGTM! thank you!

@athomas
Copy link
Member

athomas commented Mar 10, 2023 •
edited
Loading

LGTM

@nshahan: please have someone review the CLs so they're ready to land. Nevermind, it was only test matrix changes so I reviewed them.

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Mar 10, 2023
@itsjustkevin
Copy link
Contributor

@nshahan cherry-pick approved. Please merge once all tests pass.

@athomas athomas removed the cherry-pick-review Issue that need cherry pick triage to approve label Mar 13, 2023
@nshahan
Copy link
Contributor Author

nshahan commented Mar 15, 2023

Submitted.

@nshahan nshahan closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
cherry-pick-approved Label for approved cherrypick request merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sigmundch @vsmenon @nshahan @itsjustkevin @mit-mit @athomas