Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime...." and "...[dart2wasm] Improve ClassInfo field validation error messages #57055

Closed
jyameo opened this issue Nov 8, 2024 · 5 comments
Closed

Failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime...." and "...[dart2wasm] Improve ClassInfo field validation error messages #57055

jyameo opened this issue Nov 8, 2024 · 5 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jyameo
Copy link
Contributor

jyameo commented Nov 8, 2024

There are new test failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory""...[dart2wasm] Improve ClassInfo field validation error messages.

The tests

hot_reload/delete_static_field Fail (expected Pass)
hot_reload/existing_static_field_changes_type_indirect_function Fail (expected Pass)
hot_reload/existing_static_field_changes_type_indirect_generic Fail (expected Pass)
standalone/io/unix_socket_test RuntimeError (expected Pass)

are failing on configurations

ddc-canary-linux-chrome
vm-reload-linux-release-x64

LOGS:

CC @bkonyi @derekxu16 @a-siva
@dart-github-bot
Copy link
Collaborator

Summary: The reland of "[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime" and "[dart2wasm] Improve ClassInfo field validation error messages" introduced test failures in hot reload and standalone/io/unix_socket_test on ddc-canary-linux-chrome and vm-reload-linux-release-x64 configurations.

@dart-github-bot dart-github-bot added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 8, 2024
@jyameo jyameo changed the title Failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory""...[dart2wasm] Improve ClassInfo field validation error messages Failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime...." and "...[dart2wasm] Improve ClassInfo field validation error messages Nov 8, 2024
@a-siva
Copy link
Contributor

a-siva commented Nov 8, 2024

These failures seem unrelated to the changes.
It looks like the tests are flaky

@devoncarew devoncarew added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Nov 8, 2024
@devoncarew devoncarew mentioned this issue Nov 8, 2024
Open
@bkonyi bkonyi added gardening area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Nov 11, 2024
@bkonyi
Copy link
Contributor

bkonyi commented Nov 11, 2024

FYI @natebiggs for the failing / flaky DDC hot reload tests.

@nshahan
Copy link
Contributor

nshahan commented Nov 13, 2024

cc @Markzipan

The following tests were added by 5b01285 which is within the range of flagged CLs. The failures on ddc-canary-linux-chrome are expected at this time.

hot_reload/delete_static_field
hot_reload/existing_static_field_changes_type_indirect_function
hot_reload/existing_static_field_changes_type_indirect_generic

@nshahan nshahan removed the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Nov 13, 2024
@a-siva
Copy link
Contributor

a-siva commented Nov 13, 2024

I think we can close this issue as I presume the hot reload test failures on the web are being tracked

@a-siva a-siva closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@devoncarew @nshahan @jyameo @a-siva @bkonyi @dart-github-bot