Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code on lint failures #57217

Closed
danschultz opened this issue Jun 2, 2015 · 1 comment
Closed

Exit code on lint failures #57217

danschultz opened this issue Jun 2, 2015 · 1 comment
Assignees
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug

Comments

@danschultz
Copy link

Should the linter return a non-zero exit code if a source file fails a lint? The linter is always returning 0, which makes it difficult for a script to know if linting fails without having to parse the result.

@pq
Copy link
Member

pq commented Jun 2, 2015

👍

Ideally the linter CLI should be consistent with the analyzer_cli which bases it's exit code on the ordinal value of the severity of the analysis error. In the case of lints, which are treated as INFOs, that would be 1. NONE is, as you'd expect, 0.

I'll take a look at this. Thanks for the report!

@pq pq added the type-enhancement A request for a change that isn't a bug label Jun 2, 2015
@pq pq self-assigned this Jun 2, 2015
@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 18, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants