Skip to content

overridden_fields should not report if the parent field is abstract #58240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a14n opened this issue Oct 8, 2020 · 0 comments · Fixed by dart-archive/linter#2285
Closed

overridden_fields should not report if the parent field is abstract #58240

a14n opened this issue Oct 8, 2020 · 0 comments · Fixed by dart-archive/linter#2285
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@a14n
Copy link
Contributor

a14n commented Oct 8, 2020

With NNBD field can be abstract and it should be ok to override an abstract field.

class A { abstract String s; }
class B extends A {
  @override // should be ok
  String s; 
}
@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) linter-false-positive labels Oct 9, 2020
@pq pq mentioned this issue Oct 12, 2020
Merged
@pq pq self-assigned this Oct 12, 2020
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
@eernstg eernstg mentioned this issue Jun 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow overriding abstract fields in NNBD dart-archive/linter
4 participants
@pq @srawlins @a14n @devoncarew