Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null safety #58295

Closed
scheglov opened this issue Dec 31, 2020 · 2 comments
Closed

Migrate to null safety #58295

scheglov opened this issue Dec 31, 2020 · 2 comments
Assignees
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/176486 will (hopefully) migrate package:analyzer to null safety.
But at least several tests are failing, because they expect that package:linter is available, and rules are registered. But we cannot make it available because importing an unmigrated library into a migrated test library file leads to a run error (to prevent accidentally think that you are null safe while you are not). So, we disable these tests.

Also most of the clients of package:analyzer externally (analyzer_cli) and internally (g3_analyzer_cli) register lint rules. This means that these clients cannot be made null safe until package:linter is migrated.

Then we will able to re-enable tests.

@pq pq self-assigned this Jan 4, 2021
@pq
Copy link
Member

pq commented Jan 4, 2021

This is exciting!

I started on this a bit ago and will restore my branch and get back to it.

Let's touch base and coordinate when everyone is back from holiday?

@pq
Copy link
Member

pq commented Jan 6, 2021

@pq pq closed this as completed Mar 26, 2021
@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

3 participants