Skip to content

deprecate avoid_returning_null under null safety #58332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kevmoo opened this issue Feb 27, 2021 · 5 comments
Closed

deprecate avoid_returning_null under null safety #58332

kevmoo opened this issue Feb 27, 2021 · 5 comments
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@kevmoo
Copy link
Member

kevmoo commented Feb 27, 2021 •
edited
Loading

lot's of noise!

see #58100
@kevmoo kevmoo added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Feb 27, 2021
@pq pq added the type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable label Mar 1, 2021
@pq
Copy link
Member

pq commented Mar 1, 2021

/fyi @munificent @bwilkerson

@bwilkerson
Copy link
Member

@kevmoo Could you be more specific about the kind(s) of noise that you're seeing? I'd like to better understand the problem in order to understand the solution.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 1, 2021 •
edited
Loading

Before null-safety, you don't want giveMeInt() to return null, because it breaks 5 + giveMeInt().

With any package opting into null-safety, you now get the right static hints.

I'd say we say this lint is obsolete/deprecated for null-safe packages

@bwilkerson
Copy link
Member

Agreed. Just wanted to know if there was more to it than that.

@pq
Copy link
Member

pq commented Aug 4, 2021

Closing in favor of #58394. (TL;DR: yes, let's!)

@pq pq closed this as completed Aug 4, 2021
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @pq @devoncarew @bwilkerson