Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stale entries from rules.json #59176

Closed
pq opened this issue Jun 5, 2023 · 4 comments · Fixed by dart-lang/linter#4435
Closed

remove stale entries from rules.json #59176

pq opened this issue Jun 5, 2023 · 4 comments · Fixed by dart-lang/linter#4435
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Jun 5, 2023

I'd like to remove a few things from our generated json descriptions of lint rules (https://github.com/dart-lang/linter/blob/gh-pages/lints/machine/rules.json).

Specifically, I'd like to remove:

@parlough, @devoncarew: do you have any idea who (if anyone) is using this file?

(I feel like I put this together for @csells a while back but can't recall how it's use has evolved...)

@pq pq added the P2 A bug or feature request we're likely to work on label Jun 5, 2023
@devoncarew
Copy link
Member

From dart-lang/lints, we're using name and description (and may end up using hasFix).

@parlough
Copy link
Member

parlough commented Jun 5, 2023

We currently use it to generate https://dart.dev/tools/linter-rules but I imagine that might change in the future.

However, we don't use maturity or sinceLinter anymore, so those should be safe to remove for dart.dev :)

Thanks for checking!

@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 19, 2024
@csells
Copy link

csells commented Nov 19, 2024

no tools I know of use either of those two field, @pq

@devoncarew
Copy link
Member

Hi - this issue just got re-pinged due to the repo transfer (dart-lang/linter#5127).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants