Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

await_only_futures support for extension types #59252

Closed
Tracked by #58838
bwilkerson opened this issue Aug 12, 2023 · 1 comment
Closed
Tracked by #58838

await_only_futures support for extension types #59252

bwilkerson opened this issue Aug 12, 2023 · 1 comment
Assignees
@pq
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. devexp-linter Issues with the analyzer's support for the linter package linter-new-language-feature linter-set-core P3 A lower priority bug or feature request

Comments

@bwilkerson
Copy link
Member

The await_only_futures lint should not generate a lint if the type of the expression is an extension type. It is a compile-time error to await an expression whose type is an extension type that doesn't implement Future, so the reporting in that case is duplicated.
@pq pq mentioned this issue Nov 19, 2024
Open
44 tasks
@bwilkerson bwilkerson added the P3 A lower priority bug or feature request label Aug 14, 2023
@pq pq self-assigned this Aug 24, 2023
copybara-service bot referenced this issue Aug 24, 2023
@pq
extension type support for await_only_futures
c1cacbe 
Fixes: https://github.com/dart-lang/linter/issues/4685

Change-Id: I7cbc1a2a99384d7bc049e4e98ce3de53209398dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq
Copy link
Member

pq commented Aug 24, 2023

Fixed w/ c1cacbe.

@pq pq closed this as completed Aug 24, 2023
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. devexp-linter Issues with the analyzer's support for the linter package linter-new-language-feature linter-set-core P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @devoncarew @bwilkerson