Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer_const_constructors_in_immutables support for extension types #59275

Closed
Tracked by #58838
pq opened this issue Aug 25, 2023 · 3 comments
Closed
Tracked by #58838

prefer_const_constructors_in_immutables support for extension types #59275

pq opened this issue Aug 25, 2023 · 3 comments
Assignees
@pq
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. linter-new-language-feature linter-set-flutter P3 A lower priority bug or feature request

Comments

@pq
Copy link
Member

pq commented Aug 25, 2023 •
edited
Loading

More discussion: #53351.

The question is whether we want to treat extension types as effectively annotated @immutable (since they essentially are) and lint all non const constructors on extension types.

/cc @goderbauer @a14n @eernstg
@pq pq added P3 A lower priority bug or feature request linter-new-language-feature labels Aug 25, 2023
@pq pq self-assigned this Aug 25, 2023
@pq pq mentioned this issue Nov 19, 2024
Open
44 tasks
@pq pq mentioned this issue Nov 20, 2024
Closed
@pq
Copy link
Member Author

pq commented Aug 31, 2023

As per the discussion in #53351, there might be good reasons for non-const constructors in extension types so it's reasonable to allow annotating them with @immutable and get the benefits of this lint.

copybara-service bot referenced this issue Oct 11, 2023
@pq
fix prefer_void_to_null false positive on extension type representa…
d9731ac 
…tions

Fixes: https://github.com/dart-lang/linter/issues/4720

Change-Id: Ie3a736cbd4d190135eb77932ec8ba9352683226e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq
Copy link
Member Author

pq commented Oct 11, 2023 •
edited
Loading

(linked from wrong PR)

@pq pq closed this as completed Oct 11, 2023
@pq pq reopened this Oct 11, 2023
copybara-service bot referenced this issue Oct 12, 2023
@pq
extension type support for prefer_const_constructors_in_immutables
532e467 
Fixes: https://github.com/dart-lang/linter/issues/4720

Change-Id: Ia55289f53b6191e8511664cfa5b05ebcfe42ed6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
@pq
Copy link
Member Author

pq commented Oct 12, 2023

Fixed w/ 532e467.

@pq pq closed this as completed Oct 12, 2023
@devoncarew devoncarew added analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-lang/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. linter-new-language-feature linter-set-flutter P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @devoncarew