frog fails on local storage demo

[dgrove]

Revision: r2354

This application runs fine on dartc, but fails on frog.

I've attached the failing code when compiled by frog.

After discussion with sra@, I am betting this is a problem with DOM libs rather than an issue with frog itself

---

Attachments:
LocalStorage.html (209 Bytes)
LocalStorage.dart (1.02 KB)
LocalStorage.dart.app.js (137.83 KB)

[vsmenon]

Can you add some info on where this is failing? Do you see any errors on the JS console?

[dgrove]

There are exceptions in the JS console. I don't have them handy now, but
they should reproduce trivially with the attachments.

[vsmenon]

Hmm, the problem is that the Storage.dartObjectLocalStorage "field" is broken for this type. On every other DOM type, we create an expando. Here, we actually define something in LocalStorage with "dartObjectLocalStorage" as a key.

The dart:html layer relies on this field working correctly. Still investigating how to workaround this.

[vsmenon]

Issue #842 has been merged into this issue.

[vsmenon]

Issue #828 has been merged into this issue.

[vsmenon]

Note, the same bug occurs with sessionStorage (bug 828, merged in).

[vsmenon]

Note, we can workaround this quickly in dart:html by avoiding the Storage.dartObjectLocalStorage "field". But, I'd prefer to make this field work properly. Running into some frog issues there.

[dgrove]

Vijay, can we get an update on this?

[vsmenon]

Getting back to this now.

---

Added Accepted label.

[vsmenon]

Fixed in 3204.

---

Added Fixed label.