Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Check site against changelog #5055

Closed
7 tasks done
MaryaBelanger opened this issue Jul 10, 2023 · 3 comments
Closed
7 tasks done

[3.1] Check site against changelog #5055

MaryaBelanger opened this issue Jul 10, 2023 · 3 comments
Assignees
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work from.team Reported by Dash docs team member meta.evaluation Need to consider what changes if any are needed p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Jul 10, 2023

A few minor changes in the next release. Need to search the site for any mentions of the affected libraries in the 3.1.0 section of the CHANGELOG.

Edit: Evaluation

@MaryaBelanger MaryaBelanger self-assigned this Jul 10, 2023
@parlough
Copy link
Member

parlough commented Jul 10, 2023

@liamappelbe I'm not really familiar, but if it sticks for 3.1, does your recent callback work address any of the limitations in Callbacks and multithreading limitations on the Objective-C and Swift interop page? Or would the page (or other FFI pages) benefit from mentions of the new functionality?

@parlough parlough added p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Can complete in < 5 days of normal, not dedicated, work e3-weeks Complete in < 4 weeks of normal, not dedicated, work meta.evaluation Need to consider what changes if any are needed release and removed e3-weeks Complete in < 4 weeks of normal, not dedicated, work labels Jul 10, 2023
@liamappelbe
Copy link
Contributor

@parlough Async callbacks have landed in 3.1, under the NativeCallable.listener API. The goal is to address those multithreading limitations, but I'll need to add support for these callbacks in ffigen first. Since ffigen is not tied to SDK releases, we can update those docs when that support lands.

But it's probably worth mentioning NativeCallable.listener if there's anywhere in the docs that mentions Pointer.fromFunction. They're not specific to ObjC interop.

@parlough
Copy link
Member

Thanks for the explanation! I'll be on the lookout for the ffigen changes then :)

As for Pointer.fromFunction, we don't mention it currently, as our ffi docs are still rather limited, so we should be good (excluding docs we still need to add either way).

@MaryaBelanger MaryaBelanger changed the title Check site for 3.1 changes [3.1] Check site against changelog Jul 21, 2023
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Aug 1, 2023
@atsansone atsansone added the from.team Reported by Dash docs team member label Aug 8, 2023
@atsansone atsansone removed the release label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2-days Can complete in < 5 days of normal, not dedicated, work from.team Reported by Dash docs team member meta.evaluation Need to consider what changes if any are needed p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

No branches or pull requests

4 participants