Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pub -> .dart_tool/pub #571

Closed
kwalrath opened this issue Feb 12, 2018 · 3 comments
Closed

.pub -> .dart_tool/pub #571

kwalrath opened this issue Feb 12, 2018 · 3 comments
Assignees
Milestone

Comments

@kwalrath
Copy link
Contributor

Soon the place where pub hides its files will change (see dart-lang/sdk#32030). We need to update pages and scripts that refer to the old place. I found the following mentions of .pub:

  • site-www/src/_guides/libraries/private-files.md:.pub/
  • site-www/src/_tutorials/dart-vm/get-started.md:.pub
  • site-www/src/tools/pub/cmd/pub-get.md:packages directories, or .pub directory (when present)

I should also fix, site-www/src/tools/pub/installing.md, which refers to .pub_cache (but should presumably be .pub-cache; I believe ~/.pub-cache is unaffected).

@kwalrath kwalrath added this to the 2-dev milestone Feb 13, 2018
@chalin chalin modified the milestones: 2-beta2, 2-beta3 Apr 14, 2018
@chalin chalin modified the milestones: 2-beta3, 2-beta4 May 3, 2018
@bcko
Copy link
Contributor

bcko commented May 24, 2018

@kwalrath @chalin
The first two pages are already updated as shown below.

https://github.com/dart-lang/site-www/blob/master/src/_guides/libraries/private-files.md

Don’t commit the following files and directories created by pub:

.dart_tool/
.packages
build/
pubspec.lock  // Except for application packages

https://github.com/dart-lang/site-www/blob/master/src/_tutorials/dart-vm/get-started.md

Some of the files and directories in the hello_world app include the following:
.dart_tool
Support files used by pub and other Dart tools. You can ignore this.

I wasn't sure about the third page.
The third page mentions doesn't mention .pub but .pub-cache and packages.

@kwalrath
Copy link
Contributor Author

kwalrath commented Jun 7, 2018

Thanks for checking, @bcko! I'll take a look at the third page.

@kwalrath kwalrath self-assigned this Jun 7, 2018
@chalin chalin added the Dart2 label Jun 14, 2018
@chalin chalin modified the milestones: 2-beta, 2.0 Aug 9, 2018
@kwalrath
Copy link
Contributor Author

kwalrath commented Aug 17, 2018

I just took another look at these pages, and the references to .pub* filenames all seem to be correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants