Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace arguments that can be String or Uri with Uri #47

Open
natebosch opened this issue Jun 5, 2020 · 1 comment
Open

Replace arguments that can be String or Uri with Uri #47

natebosch opened this issue Jun 5, 2020 · 1 comment
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump

Comments

@natebosch
Copy link
Member

Things are safer and it is trivial to shift the Uri.parse to the call site for the use cases passing a String.
@natebosch natebosch added the next-breaking-release Issues that are worth doing but need to wait for a breaking version bump label Jun 5, 2020
@natebosch
Copy link
Member Author

Also some arguments are String uri, like https://pub.dev/documentation/source_maps/latest/source_maps.parser/Mapping/spanFor.html

This should likely be Uri.

@natebosch natebosch mentioned this issue Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-breaking-release Issues that are worth doing but need to wait for a breaking version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natebosch