Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more efficient with String.fromCharCodes #44

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Be more efficient with String.fromCharCodes #44

merged 1 commit into from
Nov 7, 2019

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Nov 7, 2019

Fixes #37

Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

@kevmoo
Copy link
Member Author

kevmoo commented Nov 7, 2019

Changelog?

Meh. No behavior change. Won't affect most folks.

@kevmoo kevmoo merged commit a5f8ead into master Nov 7, 2019
@kevmoo kevmoo deleted the i37_better branch November 7, 2019 23:26
natebosch added a commit that referenced this pull request Nov 14, 2019
This reverts commit a5f8ead.

This caused an unknown issue in rare cases with the test package.
natebosch added a commit that referenced this pull request Nov 14, 2019
This reverts commit a5f8ead.

This caused an unknown issue in rare cases with the test package.
nex3 pushed a commit to nex3/source_span that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceFile.getText is doing too many allocations
3 participants