-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused Chain.disable functionality #121
Comments
Hmm, we might not be able to do a major version release because of flutter pinning. 😢 |
No real opinion on removing the behavior. Sure, go for it! The implementation looks potentially unsafe. If you disable stack chaining using this function, then start a new stack chaining inside it, then the value won't be correct. (It will enable the outer stack chaining zone as well). The test, if anything, should be (Don't read |
If there is no known usage, I would be ok with removing this as a minor version bump. It will likely cause less pain than revving the whole ecosystem. |
I cannot find any uses of the
Chain.disable
API outside of the tests in this package. It is unnecessary complexity. Removing the functionality may also remove some of the overhead from this package since we can omit a boolean check and reading a zone variable for every zone callback.Any concerns @jakemac53 @lrhn ?
The text was updated successfully, but these errors were encountered: