Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub run test -p dartium looks for the dartium binary; the binary is actually named chrome #353

Closed
kevmoo opened this issue Oct 18, 2015 · 5 comments
Labels
closed-as-intended Closed as the reported issue is expected behavior

Comments

@kevmoo
Copy link
Member

kevmoo commented Oct 18, 2015

From @jirkadanek on October 17, 2015 17:55

I'm running dart test using the test package..

pub run test -p dartium

When I execute the command above, I get the following error.

Failed to run Dartium: No such file or directory
    Command: dartium --user-data-dir=/tmp/dart_test_pLppGJ http://localhost:59531/nI6HuPYC2TYNlxlFC2UiMNf4eBs9I0iJ/packages/test/src/runner/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A59531%2FnI6HuPYC2TYNlxlFC2UiMNf4eBs9I0iJ%2F0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate.
dart:isolate  _RawReceivePortImpl._handleMessage

I have both dartium and dart.sdk downloaded and in PATH.
The version is 1.13.0-dev.7.0 (Wed Oct 14 06:04:50 2015) on "linux_x64"

The same issue was discussed four months ago at https://stackoverflow.com/questions/30675583/failed-to-load-dartium-when-running-test
The solution described there, ln -s chrome dartium in the directory where I unpacked Dartium works for me.

I would expect pub run test to work without me having to create any symlinks.

Copied from original issue: dart-lang/sdk#24616

@nex3
Copy link
Member

nex3 commented Oct 19, 2015

As the README notes, this is intentional. We can't very well search for an executable called chrome and expect it to be Dartium. We need some way of having the user explicitly specify where Dartium in particular is, and this is the most straightforward (and compatible with Homebrew).

Once #63 is fixed, there will be a more explicit way of configuring your Dartium location.

@nex3 nex3 closed this as completed Oct 19, 2015
@nex3 nex3 added the closed-as-intended Closed as the reported issue is expected behavior label Oct 19, 2015
@jiridanek
Copy link

What about renaming the Dartium executable in dartium-linux-x64-release.zip to dartium? That is why I originally opened the issue at dart-lang/sdk#24616 --- I think the SDK should be changed, not the test package.

@nex3
Copy link
Member

nex3 commented Oct 19, 2015

For that, I suggest opening another issue against the SDK that's more specific about what change you're asking for.

@jiridanek
Copy link

@nex3 So you think this is a good idea? I was a bit worried that renaming anything would be out of the question. Renaming would break compatibility with previous releases, and having both chrome and dartium in the directory would be a confusing mess...

@nex3
Copy link
Member

nex3 commented Oct 19, 2015

It's not my decision. I've always thought it was a bit strange that it was called chrome, but I'm not in a great position to weight the costs and benefits of changing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-as-intended Closed as the reported issue is expected behavior
Projects
None yet
Development

No branches or pull requests

3 participants