-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Considering deprecating and discontinuing package:oauth2 #375
Comments
Would be sad to see it abonded, i use it in quite a few flutter projects because it's pretty easy to understand and reason about, without many dependencies. Last time I researched alternatives, most were pretty opinionated about how they store credentials, or do it on there own internally, or even try to handle redirects as flutter plugins. |
Same from me, I use it in several projects and also use it in a plugin oauth_webauth. Really sad to see discontinuing this package which is so simple to use and provide so clean pure dart implementation of OAuth2 grant types. I hope a different destiny for this package instead of discontinuing it. |
Also removes package:oauth2 from DEPS (it is now vendored in pub). See https://github.com/dart-lang/oauth2/issues/137. Changes: ``` > git log --format="%C(auto) %h %s" 65c7f3e..6ac42d7 https://dart.googlesource.com/pub.git/+/6ac42d76 Use package:vendor to vendor package:tar and package:oauth2 (#3638) https://dart.googlesource.com/pub.git/+/817fcf13 blast_repo fixes (#3646) https://dart.googlesource.com/pub.git/+/738d963c blast_repo fixes (#3644) https://dart.googlesource.com/pub.git/+/a73598b5 Refactor HTTP retries (#3325) (#3590) https://dart.googlesource.com/pub.git/+/5527068c New command `dart pub cache preload` (#3636) ``` Diff: https://dart.googlesource.com/pub.git/+/65c7f3e528f3f9978c4330cbd471070f17370f65~..6ac42d7644dedfcc500147ab47886eecab4b1b38/ Change-Id: I6d2dffcac67b4bd1c1c91be952cca65c84d85493 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269301 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com>
I use this package also, would be pretty sad if you plan to discontinue it |
@devoncarew would it be possible to transfer this package under https://github.com/flutter/packages ? even though this package doesn't depend on flutter, we can split it in 2 packages:
|
oauth2 is the cornerstone of modern APIs; It is critical that there exists a good solution here. If Google can't maintain this repo, perhaps they can fund an organization that will? Like the flutter firebase plugins - which are Google sponsored but maintained by a 3rd party. EDIT: I know this is a pretty big ask ;-) (Google can't fund everything). But if its a case of "we have money, but not people" this could be a way forward. |
Very saddened by this announcement. |
Has any decision been made on this? |
Any updates on this package? |
We have launched package:oidc, which is the most comprehensive openid connect/oauth package to date. |
I'm checking the oidc plugin but i see no example on something as simple as a google signin |
@joaquingrech there is an entire example project here as with any oauth plugin, after the initial setup, you put your client id, secret, redirect url and discovery document, and manage it using |
well, i tried that example project placing google URLs and it didn't work. That's why I'm asking, it seems there are zero examples on the web using this library to create a mobile app and auth on it. |
yeah, i repeat myself, after 4 hours trying to use OIDC package, I failed not even getting a simple google login page to load. Zero examples on the web, zero examples on the doc. The documentation and readme are obsolete (missing all parameters on main page). OAuth package was working fine. If this is to replace the previous package, it has to catchup with at the bare minimum, a google login example since it's the most used login in the world. |
Once some of the work is completed on native asset bundling could it make sense that this packaged was just rewritten to wrap a more robust implementation that wasn’t written in Dart as an alternative way of reducing the maintenance burden while improving some of the building blocks available to the server side Dart community? |
This is a tracking issue for potentially deprecating and discontinuing
package:oauth2
.General notes:
tools.dart.dev
publisher; for people who are not aware, that publisher is for packages we've authored in order to build various Dart tools (pub, analyzer, ...)tools.
packages is lower than for generaldart.dev
packages ; the packages are triaged occasionally, we may not be able to respond to all issues; essentially, we're ok with people taking a dependency on them but the packages don't have a strong support commitmentpackage:oauth2
is from the pub tool; that team doesn't have the bandwidth to maintain this package beyond the parts that they themselves useParaphrasing from the above, we don't have the bandwidth to maintain this package as a general purpose solution, and from the issues and PRs, there some clear maintenance technical debt. Given that this package is from the Dart team, people can mis-interpret the intent to be to provide a general purpose or best-of-breed solution.
An alternative to the current situation is to:
We'll leave this issue open for a few weeks while we collect feedback; thanks in advance!
Other data points:
The text was updated successfully, but these errors were encountered: