Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in PollingDirectoryWatcher #69

Closed
grouma opened this issue May 22, 2019 · 1 comment
Closed

Race condition in PollingDirectoryWatcher #69

grouma opened this issue May 22, 2019 · 1 comment

Comments

@grouma
Copy link
Member

grouma commented May 22, 2019

I believe there is a race condition here:
https://github.com/dart-lang/watcher/blob/master/lib/src/directory_watcher/polling.dart#L136

Between polling for the list of files to watch and running getModificationTime, the underlying file could have been deleted or moved. This will result in an unhandled failure.
@grouma grouma mentioned this issue May 22, 2019
Closed
@natebosch natebosch mentioned this issue May 22, 2019
Merged
@grouma grouma mentioned this issue May 22, 2019
Closed
@grouma
Copy link
Member Author

grouma commented Jun 18, 2019

This is likely not an issue.

@grouma grouma closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race condition in PollingDirectoryWatcher dart-lang/watcher
1 participant
@grouma