Catch exceptions in unawaited Futures (#1938)

Author: elliette

dwds/lib/shared/batched_stream.dart

@@ -4,6 +4,7 @@
 
 import 'dart:async';
 import 'package:async/async.dart';
+import 'package:dwds/src/utilities/shared.dart';
 
 /// Stream controller allowing to batch events.
 class BatchedStreamController<T> {
@@ -28,7 +29,7 @@ class BatchedStreamController<T> {
         _inputController = StreamController<T>(),
         _outputController = StreamController<List<T>>() {
     _inputQueue = StreamQueue<T>(_inputController.stream);
-    unawaited(_batchAndSendEvents());
+    safeUnawaited(_batchAndSendEvents());
   }
 
   /// Sink collecting events.
@@ -39,7 +40,7 @@ class BatchedStreamController<T> {
 
   /// Close the controller.
   Future<dynamic> close() async {
-    unawaited(_inputController.close());
+    safeUnawaited(_inputController.close());
     return _completer.future.then((value) => _outputController.close());
   }
 

dwds/lib/src/connections/app_connection.dart

@@ -9,6 +9,7 @@ import 'package:dwds/data/connect_request.dart';
 import 'package:dwds/data/run_request.dart';
 import 'package:dwds/data/serializers.dart';
 import 'package:dwds/src/handlers/socket_connections.dart';
+import 'package:dwds/src/utilities/shared.dart';
 
 /// A connection between the application loaded in the browser and DWDS.
 class AppConnection {
@@ -19,7 +20,7 @@ class AppConnection {
   final SocketConnection _connection;
 
   AppConnection(this.request, this._connection) {
-    unawaited(_connection.sink.done.then((v) => _doneCompleter.complete()));
+    safeUnawaited(_connection.sink.done.then((v) => _doneCompleter.complete()));
   }
 
   bool get isInKeepAlivePeriod => _connection.isInKeepAlivePeriod;

dwds/lib/src/debugging/debugger.dart

@@ -16,6 +16,7 @@ import 'package:dwds/src/utilities/conversions.dart';
 import 'package:dwds/src/utilities/dart_uri.dart';
 import 'package:dwds/src/utilities/domain.dart';
 import 'package:dwds/src/utilities/objects.dart' show Property;
+import 'package:dwds/src/utilities/server.dart';
 import 'package:dwds/src/utilities/shared.dart';
 import 'package:dwds/src/utilities/synchronized.dart';
 import 'package:logging/logging.dart';

dwds/lib/src/debugging/inspector.dart

@@ -17,6 +17,7 @@ import 'package:dwds/src/readers/asset_reader.dart';
 import 'package:dwds/src/utilities/conversions.dart';
 import 'package:dwds/src/utilities/dart_uri.dart';
 import 'package:dwds/src/utilities/domain.dart';
+import 'package:dwds/src/utilities/server.dart';
 import 'package:dwds/src/utilities/shared.dart';
 import 'package:logging/logging.dart';
 import 'package:vm_service/vm_service.dart';

dwds/lib/src/debugging/metadata/function.dart

@@ -4,7 +4,7 @@
 
 import 'package:dwds/src/debugging/remote_debugger.dart';
 import 'package:dwds/src/loaders/strategy.dart';
-import 'package:dwds/src/utilities/shared.dart';
+import 'package:dwds/src/utilities/server.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
 /// Meta data for a remote Dart function in Chrome.

dwds/lib/src/handlers/dev_handler.dart

@@ -31,6 +31,7 @@ import 'package:dwds/src/servers/extension_backend.dart';
 import 'package:dwds/src/services/app_debug_services.dart';
 import 'package:dwds/src/services/debug_service.dart';
 import 'package:dwds/src/services/expression_compiler.dart';
+import 'package:dwds/src/utilities/shared.dart';
 import 'package:logging/logging.dart';
 import 'package:shelf/shelf.dart';
 import 'package:sse/server/sse_handler.dart';
@@ -159,7 +160,7 @@ class DevHandler {
           .takeUntilGap(const Duration(milliseconds: 50));
       // We enqueue this work as we need to begin listening (`.hasNext`)
       // before events are received.
-      unawaited(Future.microtask(() => connection.runtime.enable()));
+      safeUnawaited(Future.microtask(() => connection.runtime.enable()));
 
       await for (var contextId in contextIds) {
         final result = await connection.sendCommand('Runtime.evaluate', {
@@ -175,7 +176,7 @@ class DevHandler {
         }
       }
       if (appTab != null) break;
-      unawaited(connection.close());
+      safeUnawaited(connection.close());
     }
     if (appTab == null || tabConnection == null || executionContext == null) {
       throw AppConnectionException(
@@ -234,7 +235,7 @@ class DevHandler {
           await _chromeConnection(), appConnection);
       appServices = await _createAppDebugServices(
           appConnection.request.appId, debugService);
-      unawaited(appServices.chromeProxyService.remoteDebugger.onClose.first
+      safeUnawaited(appServices.chromeProxyService.remoteDebugger.onClose.first
           .whenComplete(() async {
         await appServices?.close();
         _servicesByAppId.remove(appConnection.request.appId);
@@ -301,7 +302,7 @@ class DevHandler {
       }
     });
 
-    unawaited(injectedConnection.sink.done.then((_) async {
+    safeUnawaited(injectedConnection.sink.done.then((_) async {
       _injectedConnections.remove(injectedConnection);
       final connection = appConnection;
       if (connection != null) {
@@ -533,7 +534,8 @@ class DevHandler {
         );
         final encodedUri = await debugService.encodedUri;
         extensionDebugger.sendEvent('dwds.encodedUri', encodedUri);
-        unawaited(appServices.chromeProxyService.remoteDebugger.onClose.first
+        safeUnawaited(appServices
+            .chromeProxyService.remoteDebugger.onClose.first
             .whenComplete(() async {
           appServices?.chromeProxyService.destroyIsolate();
           await appServices?.close();