Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdev (2.5.6) serve (dartdevc) compilation fails with 2.8.0-dev.15.0 #936

Closed
whesse opened this issue Mar 24, 2020 · 5 comments
Closed
Labels
package:webdev type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@whesse
Copy link

whesse commented Mar 24, 2020

The non-release, dartdevc build of my Dart Angular web app is failing with dev SDK releases 2.8.0-dev.15.0 and 2.8.0-dev.16.0. It is working with 2.8.0-dev.10.0, and probably most of the ones between dev.10 and dev.15, I'll narrow it down more. Webdev is 2.5.6

I'm unclear whether this is a webdev problem or a dartdevc problem, or specific to the interface between the two. The error I see is "Bad state: Process is detached" when it tries to run the ddc compiler.

I'll look into debugging this, running in verbose modes, and pinning down the version where the problem begins. The problem can be reproduced by checking out the dart-lang/dart_ci repository and trying to build with the command:

pub global run webdev serve web:53322 --no-release -v

The stack trace shows a failure in bazel_worker, but it looks like the process it started got detached, not a bug in the bazel_worker code. Because public angular has not been updated in a year, it had some conflicting old dependencies, so I also tried updating them, but got the same result. My overrides (which made no difference to the failure) are:

dependency_overrides:
  bazel_worker: '0.1.23'
  protobuf: '>=0.14.4'
[INFO]Heartbeat: 28.4s elapsed, 4080/4090 actions completed.
[FINE]angular:angular on package:angular_test/compatibility.dart: Running AngularDart Compiler
[SEVERE]build_web_compilers:ddc on package:intl/date_symbols.ddc.module: Bad state: Process is detached
#0      _ProcessImpl.exitCode (dart:io-patch/process_patch.dart:546:29)
#1      BazelWorkerDriver._runWorkQueue.<anonymous closure> (package:bazel_worker/src/driver/driver.dart:116:16)
#2      _rootRunUnary (dart:async/zone.dart:1134:38)
#3      _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#4      _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#5      Future._propagateToListeners.handleValueCallback (dart:async/future_impl
@whesse whesse added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) package:webdev labels Mar 24, 2020
@jakemac53
Copy link
Contributor

You will need to update your bazel_worker version to the latest, there was a breaking change in the sdk which broke that package.

@jakemac53
Copy link
Contributor

(specifically, you need version 0.1.23+1)

@whesse
Copy link
Author

whesse commented Mar 24, 2020

This seems to be an unfixable breakage in the angular workflow now, because if I use bazel_worker 0.1.23+1, then I need to use protobuf 0.14.4, and angular framework code breaks with protobuf 0.14.4.

I will file an issue against Dart angular about this.
The workaround is to use dart2js by adding the --release flag to webdev serve.

@jakemac53
Copy link
Contributor

Oh right! cc @kevmoo @vsmenon this is what I was talking about a few weeks ago

@natebosch
Copy link
Member

Side note - when pasting stack traces in github issues please surround them with code fences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:webdev type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants