Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you export boolean_point_in_polygon function #151

Closed
favazHF opened this issue Nov 14, 2023 · 4 comments
Closed

Could you export boolean_point_in_polygon function #151

favazHF opened this issue Nov 14, 2023 · 4 comments

Comments

@favazHF
Copy link

favazHF commented Nov 14, 2023

We need to use this specific function but isn't export, please.

@lukas-h
Copy link
Member

lukas-h commented Nov 15, 2023

Hi @favazHF please create a pull request for that. It would be highly appreciated

@lukas-h
Copy link
Member

lukas-h commented Feb 14, 2024

@jsiedentop I think this is one of the implemented functions that is not exported yet?
https://github.com/dartclub/turf_dart/blob/main/lib/src/booleans/boolean_point_in_polygon.dart

@jsiedentop
Copy link
Contributor

jsiedentop commented Feb 14, 2024

Exactly, so far none of the boolean functions have been exported at all. I have exported all boolean functions as part of booleanWithin #167 in package:turf/boolean.dart. But we need to take a closer look:

  • package:turf/turf.dart should export all functionality, but a lot is missing (boolean functions among others)
  • package:turf/intersection.dart is missing
  • package:turf/invariant.dart is missing
  • package:turf/line_intersect.dart is missing
  • package:turf/line_slice.dart is defined as library turf_along. Seems to be an copy paste error.
  • package:turf/extensions.dart and package:turf/cluster.dart are the only meta functionality directly exported.
  • package:turf/meta.dart has all meta files except extensions.dart. Interesting, that meta also has export 'src/line_segment.dart' hide lineSegment;

Seems to have grown historically. Maybe we should take another look at it together? @lukas-h

@lukas-h
Copy link
Member

lukas-h commented Feb 16, 2024

closing this in favor of #169, which includes the requested improvement from this issue

@lukas-h lukas-h closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants