Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart 4.1 deb on trusty has bad compilation flags #218

Closed
scpeters opened this issue Jul 8, 2014 · 3 comments
Closed

dart 4.1 deb on trusty has bad compilation flags #218

scpeters opened this issue Jul 8, 2014 · 3 comments
Milestone

Comments

@scpeters
Copy link
Collaborator

scpeters commented Jul 8, 2014

I have observed very slow performance in gazebo with the dart 4.1 debian package for Ubuntu 14.04 Trusty. The revolute joint test world is about 50 times slower than on precise. We saw some of this same behavior in ros at this issue (fixed here).

@j-rivero pointed out that the 12.04 deb build log shows -O3 in the compilation flags, while the 14.04 deb build log does not show these flags. He also recommended the following patch:

diff --git a/debian/rules b/debian/rules
index f498a10..399e333 100644
--- a/debian/rules
+++ b/debian/rules
@@ -11,3 +11,7 @@ export DH_VERBOSE=1

 %:
        dh $@
+
+override_dh_auto_configure:
+       dh_auto_configure -- \
+        -DCMAKE_BUILD_TYPE=RelWithDebInfo
@jslee02
Copy link
Member

jslee02 commented Jul 9, 2014

DART already uses compat 9 and debhelper (>=9).

I think compiling deb without -O3 flag is the reason of the slow performance as @j-rivero pointed out. The default build type in trusty deb build seems NONE so the compilation flags for release build, for example -O3, were not included. This should be fixed by setting the default build type to RelWithDebInfo in #219.

@jslee02 jslee02 added this to the Release DART 4.1.1 milestone Jul 9, 2014
@jslee02
Copy link
Member

jslee02 commented Jul 9, 2014

I believe this issue is fixed by #219. Please let me know if it is now. Thanks @scpeters and @j-rivero.

@jslee02 jslee02 closed this as completed Jul 9, 2014
@scpeters
Copy link
Collaborator Author

scpeters commented Jul 9, 2014

It looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants