Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in gtest source to the build #312

Closed
jslee02 opened this issue Jan 22, 2015 · 3 comments
Closed

Add in gtest source to the build #312

jslee02 opened this issue Jan 22, 2015 · 3 comments
Labels
priority: medium should be resolved before the next release type: bug Indicates an unexpected problem or unintended behavior
Milestone
DART 4.3.0

Comments

@jslee02
Copy link
Member

jslee02 commented Jan 22, 2015

It is not recommended by google to install a pre-compiled copy of gtest, since it needs to use the same compiler flags as DART code.

It seems fine on Ubuntu since Ubuntu provides header only gtest package, but homebrew just doesn't even recommend to install gtest header from them (gtest is on their blacklist). We should add in gtest source like Gazebo did.

Thanks @scpeters !
@jslee02 jslee02 added priority: medium should be resolved before the next release type: bug Indicates an unexpected problem or unintended behavior Comp: Build labels Jan 22, 2015
@jslee02 jslee02 added this to the Release DART 5.0 milestone Jan 22, 2015
@jslee02 jslee02 mentioned this issue Jan 22, 2015
Merged
@scpeters
Copy link
Collaborator

I've added some discussion in dartsim/homebrew-dart#3

@jslee02 jslee02 changed the title Failing in install gtest on Mac Added in gtest to the build Jan 24, 2015
@jslee02 jslee02 changed the title Added in gtest to the build Added in gtest source to the build Jan 24, 2015
@jslee02
Copy link
Member Author

jslee02 commented Jan 24, 2015

I changed this issue according to @scpeters 's recommendation.

@jslee02 jslee02 modified the milestones: Release DART 4.3, Release DART 5.0 Jan 24, 2015
@jslee02 jslee02 changed the title Added in gtest source to the build Add in gtest source to the build Jan 24, 2015
@jslee02 jslee02 mentioned this issue Jan 24, 2015
Merged
@jslee02
Copy link
Member Author

jslee02 commented Jan 24, 2015

Fixed by #315

@jslee02 jslee02 closed this as completed Jan 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium should be resolved before the next release type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
DART 4.3.0
Development

No branches or pull requests
2 participants
@scpeters @jslee02