Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation test with CI #362

Closed
jslee02 opened this issue Mar 21, 2015 · 5 comments
Closed

Installation test with CI #362

jslee02 opened this issue Mar 21, 2015 · 5 comments

Comments

@jslee02
Copy link
Member

jslee02 commented Mar 21, 2015

DART uses CI services of Travis CI and AppVeyor for build and unit tests but not installation.

@jslee02 jslee02 added this to the Release DART 5.0 milestone Mar 21, 2015
@scpeters
Copy link
Collaborator

scpeters commented Mar 21, 2015

diff --git a/ci/script_linux.sh b/ci/script_linux.sh
index 82eb3f3..283bfc3 100755
--- a/ci/script_linux.sh
+++ b/ci/script_linux.sh
@@ -1,6 +1,7 @@
  make
  sudo ldconfig --verbose # So the test executeables can detect libtinyxml2
  if [ $BUILD_CORE_ONLY = OFF ]; then make test; fi
+ sudo make install
  # cd tools/
  # ./code_check.sh
- # ./abi_check.sh 4.1.0  # Check with DART 4.1.0
\ No newline at end of file
+ # ./abi_check.sh 4.1.0  # Check with DART 4.1.0
diff --git a/ci/script_osx.sh b/ci/script_osx.sh
index 844bb27..12e416e 100755
--- a/ci/script_osx.sh
+++ b/ci/script_osx.sh
@@ -1,5 +1,6 @@
 make
 if [ $BUILD_CORE_ONLY = OFF ]; then make test; fi
+sudo make install
 # cd tools/
 # ./code_check.sh
-# ./abi_check.sh 4.1.0  # Check with DART 4.1.0
\ No newline at end of file
+# ./abi_check.sh 4.1.0  # Check with DART 4.1.0

@jslee02
Copy link
Member Author

jslee02 commented Mar 21, 2015

Thanks! I added additional script that tries to build simple DART dependent application. Would this work to prevent errors like #351?

@scpeters
Copy link
Collaborator

Yeah, that looks like it would help. We test example code that uses cmake find_package as well as pkg_check_modules (pkg-config).

@jslee02 jslee02 removed this from the Release DART 5.0 milestone Jun 11, 2015
@stale
Copy link

stale bot commented Feb 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@jslee02
Copy link
Member Author

jslee02 commented Feb 19, 2018

Addressed by #998

@jslee02 jslee02 closed this as completed Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants