Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated mark for clang #379

Closed
jslee02 opened this issue Apr 24, 2015 · 3 comments · Fixed by #384
Closed

Deprecated mark for clang #379

jslee02 opened this issue Apr 24, 2015 · 3 comments · Fixed by #384
Labels
priority: low no timeline yet tag: feature request Indicates new feature requests
Milestone
DART 5.0.0

Comments

@jslee02
Copy link
Member

jslee02 commented Apr 24, 2015

DART doesn't define deprecated mark for clang.
@mxgrey
Copy link
Member

mxgrey commented May 11, 2015

C++14 will introduce an ISO [[deprecated]] attribute tag, although I have no idea when that will be supported by GCC, Clang, and VS.

@mkoval
Copy link
Collaborator

mkoval commented May 11, 2015

Until then, it like clang implements the same extension as GCC:

  #define DEPRECATED(version) __attribute__ ((deprecated))

@jslee02
Copy link
Member Author

jslee02 commented May 12, 2015

[[deprecated]] would be a simple and portable solution when all the three compilers support it.

Meanwhile, let's use the same extension as GCC. I'll create a pull request for this.

@jslee02 jslee02 added priority: low no timeline yet tag: feature request Indicates new feature requests Comp: Common labels May 12, 2015
@jslee02 jslee02 mentioned this issue May 12, 2015
Merged
@jslee02 jslee02 added this to the Release DART 5.0 milestone May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low no timeline yet tag: feature request Indicates new feature requests
Projects
None yet
Milestone
DART 5.0.0
Development

Successfully merging a pull request may close this issue.

Add deprecated and force-inline definitions for clang dartsim/dart
3 participants
@mkoval @mxgrey @jslee02