Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Remove the requirement that Aspects are created within Composites #712

Closed
mxgrey opened this issue May 3, 2016 · 1 comment
Closed

Proposal: Remove the requirement that Aspects are created within Composites #712

mxgrey opened this issue May 3, 2016 · 1 comment
Milestone
DART 6.0.0

Comments

@mxgrey
Copy link
Member

mxgrey commented May 3, 2016

Currently, Aspect will complain if you try to construct it outside of a Composite. Furthermore, the API requires that all Aspect derivations must accept a Composite* as their first argument. This is mostly a residual design from the Addon concept.

Given how the Aspect concept has evolved away from the Addon concept, I think we should eliminate this requirement. It is already a worthless requirement since the Aspect::setComposite(~) function will be called after construction anyway.
@mxgrey mxgrey mentioned this issue May 4, 2016
Merged
@mxgrey
Copy link
Member Author

mxgrey commented May 4, 2016

Addressed by #713

@mxgrey mxgrey closed this as completed May 4, 2016
@jslee02 jslee02 added this to the DART 6.0.0 milestone May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.0.0
Development

No branches or pull requests
2 participants
@mxgrey @jslee02