-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing non RGB888 images #13
Comments
1.1.6: added -rgb parameter to convert the input to RGB888 on a fly. This is a workaround. The original pyramidio is trying to keep the tiles format identical to the input image format (which is probably a good idea). |
nice job! any rough estimate of how much overhead this conversion adds? just curious |
Not really noticeable here on my Mac. Maybe if you use really large tiles .. maybe then it will cause some memory related issues and a performance drop as the consequence. But no one uses large tiles. |
great solution! |
The original pyramidio scaling algorithm is (presumably) the source of the several issues:
#2
#1
Can be fixed by either converting the input to RGB888 on a fly or by improving the scaling algorithm in here:
https://github.com/darwinjob/pyramidio-bioformats/blob/master/pyramidio/src/main/java/gov/nist/isg/pyramidio/tools/ImageResizingHelper.java
The text was updated successfully, but these errors were encountered: