Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Let DspIngestClientLive get a fresh jwt for each request (DEV-3163) #2988

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jan 10, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Jan 10, 2024
@seakayone seakayone marked this pull request as ready for review January 10, 2024 12:50
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (eac5751) 11.74% compared to head (6bf0f92) 88.46%.
Report is 13 commits behind head on main.

Files Patch % Lines
webapi/src/main/scala/dsp/valueobjects/User.scala 64.28% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2988       +/-   ##
===========================================
+ Coverage   11.74%   88.46%   +76.71%     
===========================================
  Files         246      256       +10     
  Lines       22907    23019      +112     
===========================================
+ Hits         2690    20363    +17673     
+ Misses      20217     2656    -17561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Feel free to link this to https://linear.app/dasch/issue/DEV-3163/dsp-api-rejects-valid-requests-from-ingest-xmlupload and assign it to yourself, as you have fixed it :)

@seakayone seakayone enabled auto-merge (squash) January 10, 2024 13:07
@seakayone seakayone disabled auto-merge January 10, 2024 13:11
@seakayone seakayone merged commit 31df947 into main Jan 10, 2024
14 checks passed
@seakayone seakayone deleted the fix/remove-caching-of-dsp-client-jwt branch January 10, 2024 13:13
@seakayone seakayone changed the title fix: Let DspIngestClientLive get a fresh jwt for each request fix: Let DspIngestClientLive get a fresh jwt for each request (DEV-3163) Jan 10, 2024
Copy link

linear bot commented Jan 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants