-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix UserIri and allow existing values (DEV-3194) #2997
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
==========================================
- Coverage 11.74% 11.64% -0.10%
==========================================
Files 246 259 +13
Lines 22907 23094 +187
==========================================
- Hits 2690 2689 -1
- Misses 20217 20405 +188 ☔ View full report in Codecov by Sentry. |
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/User.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Both suggestions below can be applied separately to have this merged ASAP and release.
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/model/User.scala
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/api/UsersEndpoints.scala
Outdated
Show resolved
Hide resolved
…t contain characters which need escaping
…dpoints.scala Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
aa62184
to
c2a1109
Compare
Pull Request Checklist
Task Description/Number
This PR depends on #2996 being merged first.
Widen the allowed range of UserIris to account for existing iris in our database
http://rdfh.ch/users/
and then an alphanumeric String containing-
or_
is allows, length >=4 and <=36 charatersDELETE admin/users/iri/{userIri}
route to tapirPR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?