refactor: Move caching from UserResponder to UserService

[seakayone]

Pull Request Checklist

Task Description/Number

• Move caching of Users into UserService invalidate user on every save in the UserRepo
• Move findAllUsers from Responder to RestService

PR Type

• build/chore: maintenance tasks (no production code change)
• docs: documentation changes (no production code change)
• feat: represents new features
• fix: represents bug fixes
• perf: performance improvements
• refactor: represents production code refactoring
• test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

• Tests for the changes have been added
• Docs have been added / updated

Does this PR introduce a breaking change?

• Yes

Does this PR change client-test-data?

• Yes

[linear]

DEV-3291 Remove the `UsersResponder`

[codecov]

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.56%. Comparing base (eac5751) to head (b0360fd).
Report is 85 commits behind head on main.

Files	Patch %	Lines
...tore/cache/CacheServiceRequestMessageHandler.scala	33.33%	2 Missing ⚠️
...api/slice/admin/api/service/StoreRestService.scala	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3064       +/-   ##
===========================================
+ Coverage   11.74%   88.56%   +76.81%     
===========================================
  Files         246      262       +16     
  Lines       22907    22553      -354     
===========================================
+ Hits         2690    19973    +17283     
+ Misses      20217     2580    -17637     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[siers]

Perhaps?

    fromCache(id).flatMap {
      _.map(ZIO.some(_)).getOrElse {
        fromRepo(id).flatMap {
          ZIO.foreach(_)(toUser(_).tap(cacheService.putUser(_)))
        }
      }
    }

[BalduinLandolt]

we recently discussed that ZIO code often looks more idiomatic if optionality is moved to the E channel. Maybe that could make it even nicer?

[seakayone]

tbh, I find this less readable.

How about:

  fromCache(id).flatMap {
      case Some(user) => ZIO.some(user)
      case None       => fromRepo(id).some.flatMap(toUser(_).tap(cacheService.putUser).asSomeError).unsome
    }

[BalduinLandolt]

we recently discussed that ZIO code often looks more idiomatic if optionality is moved to the E channel. Maybe that could make it even nicer?