refactor: Migrate PUT /admin/groups/<groupIri>/status to Tapir (DEV-1588)

[mpro7]

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1588

In order to keep this PR small, needed to comment out a failing tests, which I will bring back in following PR that migrates methods related to that test.
EDIT - the above is not relevant anymore.

PR Type

• build/chore: maintenance tasks (no production code change)
• docs: documentation changes (no production code change)
• feat: represents new features
• fix: represents bug fixes
• perf: performance improvements
• refactor: represents production code refactoring
• test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

• Tests for the changes have been added
• Docs have been added / updated

Does this PR introduce a breaking change?

• Yes

Does this PR change client-test-data?

• Yes

[linear]

DEV-1588 DSP-API: Migrate admin/groups routes to tapir

[swarmia]

✅  Linked to Story DEV-1588 · DSP-API: Expose admin/groups routes with ZIO HTTP
➡️  Part of Epic DEV-1380 · C: DSP-API Introduce ZIO HTTP

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (eac5751) to head (6e0b2c2).
Report is 96 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3075       +/-   ##
===========================================
+ Coverage   11.74%   88.66%   +76.91%     
===========================================
  Files         246      263       +17     
  Lines       22907    22408      -499     
===========================================
+ Hits         2690    19867    +17177     
+ Misses      20217     2541    -17676     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[siers]

Is it a 1:1 refactor? Because some of these tapir migration PRs, I can't follow at all.

[mpro7]

Is it a 1:1 refactor? Because some of these tapir migration PRs, I can't follow at all.

I would say yes, but because this was so much spaghetti code some not directly related cleanups can appear in these PRs. Please as detailed questions, or I can give you you short walk through tomorrow morning.

[seakayone]

This PR breaks the delete group endpoint:
DELETE {{ dsp_api_url }}/admin/groups/{{groupIri}}

I have tried it out locally and get a 500 response.

Please bring back the DELETE test in GroupsADME2ESpec and fix it.

[mpro7]

This PR breaks the delete group endpoint: DELETE {{ dsp_api_url }}/admin/groups/{{groupIri}}

I have tried it out locally and get a 500 response.

Please bring back the DELETE test in GroupsADME2ESpec and fix it.

True, that why I put the short explanation in the PR description which would bring it back working in follow up PR. No matter of what, I brought it back and DELETE route as well as test are working.

[seakayone]

This PR breaks the delete group endpoint: DELETE {{ dsp_api_url }}/admin/groups/{{groupIri}}
I have tried it out locally and get a 500 response.
Please bring back the DELETE test in GroupsADME2ESpec and fix it.

True, that why I put the short explanation in the PR description which would bring it back working in follow up PR. No matter of what, I brought it back and DELETE route as well as test are working.

It's crucial to ensure that changes merged into the main branch don't break functionality, no matter the intention. Even if there's a plan to fix it later, breaking changes can disrupt the workflow for other team members. This approach can also cause confusion and frustration among team members working on dev who rely on the stability of the main branch for their work.

Moving forward, let's prioritise keeping the main branch in a stable state. This helps maintain the reliability of our codebase and ensures smoother collaboration among team members.

Thank you for your understanding and cooperation in maintaining the stability of our codebase.

[mpro7]

This PR breaks the delete group endpoint: DELETE {{ dsp_api_url }}/admin/groups/{{groupIri}}
I have tried it out locally and get a 500 response.
Please bring back the DELETE test in GroupsADME2ESpec and fix it.

True, that why I put the short explanation in the PR description which would bring it back working in follow up PR. No matter of what, I brought it back and DELETE route as well as test are working.

It's crucial to ensure that changes merged into the main branch don't break functionality, no matter the intention. Even if there's a plan to fix it later, breaking changes can disrupt the workflow for other team members. This approach can also cause confusion and frustration among team members working on dev who rely on the stability of the main branch for their work.

Moving forward, let's prioritise keeping the main branch in a stable state. This helps maintain the reliability of our codebase and ensures smoother collaboration among team members.

Thank you for your understanding and cooperation in maintaining the stability of our codebase.

Smoother collaboration in my opinion is more than the stable codebase state only. I'm not saying my way of solving this issue was perfect nor the safest. Maybe I shouldn't delete methods which were shared between both routes? Maybe I should migrate also DELETE route in this PR? Or maybe because I already removed that code and knowing the facts:

• we don't deploy main branch directly to the production, only to dev server,
• the not working route/test would be working again with next PR, which could be already ready to merge or even merged too,
  I knew it would be done nice and easy. With of course some doze of trust from your side.

Instead of that, the entire day went between bouncing the comments and waiting for the replies/re-reviews. And this is not the first time, when I have the feeling there is lack of balance between guarding the main branch and common sense, trust, cooperation on this kind of blocked by you reviews. From the other hand, it was OK for some exceptions when you are asking for them. So I would be thankful for more trust and smoother cooperation in following PRs.