-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix never-ending jobs in release PRs #3114
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
+ Coverage 11.74% 13.18% +1.44%
==========================================
Files 246 266 +20
Lines 22907 22349 -558
==========================================
+ Hits 2690 2947 +257
+ Misses 20217 19402 -815 ☔ View full report in Codecov by Sentry. |
What does this do? How can this help? Echo is already exiting with status 0. Where's the catch? |
It seems that sending only "skipped" message wasn't considered by GH as success, therefore I add |
How odd, if it's misinterpreting the "skipped"! However, echo should already return 0. Feel free to merge. |
Pull Request Checklist
Task Description/Number
This is follow-up PR of #3113 which fixed already formatting check.
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?