Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix never-ending jobs in release PRs #3114

Merged
merged 2 commits into from
Mar 21, 2024
Merged

chore: Fix never-ending jobs in release PRs #3114

merged 2 commits into from
Mar 21, 2024

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Mar 12, 2024

Pull Request Checklist

Task Description/Number

This is follow-up PR of #3113 which fixed already formatting check.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 self-assigned this Mar 12, 2024
@mpro7 mpro7 changed the title chore: make required by branch rules jobs state success after skipping in release PRs chore: Make required by branch rules jobs state success after skipping in release PRs Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.18%. Comparing base (eac5751) to head (3f71786).
Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
+ Coverage   11.74%   13.18%   +1.44%     
==========================================
  Files         246      266      +20     
  Lines       22907    22349     -558     
==========================================
+ Hits         2690     2947     +257     
+ Misses      20217    19402     -815     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 changed the title chore: Make required by branch rules jobs state success after skipping in release PRs chore: Fix never-ending jobs on release PRs Mar 12, 2024
@mpro7 mpro7 marked this pull request as ready for review March 13, 2024 07:41
@mpro7 mpro7 changed the title chore: Fix never-ending jobs on release PRs chore: Fix never-ending jobs in release PRs Mar 13, 2024
@siers
Copy link
Contributor

siers commented Mar 13, 2024

What does this do? How can this help? Echo is already exiting with status 0. Where's the catch?

@mpro7
Copy link
Contributor Author

mpro7 commented Mar 13, 2024

What does this do? How can this help? Echo is already exiting with status 0. Where's the catch?

It seems that sending only "skipped" message wasn't considered by GH as success, therefore I add exit 0 signals successful execution of the script.

@siers
Copy link
Contributor

siers commented Mar 14, 2024

How odd, if it's misinterpreting the "skipped"! However, echo should already return 0. Feel free to merge.

@mpro7 mpro7 enabled auto-merge (squash) March 21, 2024 19:04
@mpro7 mpro7 merged commit f2f1fc9 into main Mar 21, 2024
13 checks passed
@mpro7 mpro7 deleted the mpro7-patch-1 branch March 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants