Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert the import style to Scala 2 #3138

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

seakayone
Copy link
Contributor

The IntelliJ editor does not support having the Scala3 cross compile style.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (eac5751) to head (5d1986f).
Report is 146 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3138       +/-   ##
===========================================
+ Coverage   11.74%   88.88%   +77.13%     
===========================================
  Files         246      266       +20     
  Lines       22907    22349      -558     
===========================================
+ Hits         2690    19864    +17174     
+ Misses      20217     2485    -17732     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The IntelliJ editor does not support having the Scala3 cross compile style.
@seakayone seakayone force-pushed the chore/revert-import-style-to-scala2 branch from 4d4a527 to 5d1986f Compare March 21, 2024 15:38
@seakayone seakayone marked this pull request as ready for review March 21, 2024 16:29
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 That's a very unfortunate reason for the revert, but if you require this, what else can you do.

Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I hope this works but also we can bring back Scala3 settings soon.

@mpro7 mpro7 merged commit 96ee921 into main Mar 21, 2024
13 checks passed
@mpro7 mpro7 deleted the chore/revert-import-style-to-scala2 branch March 21, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants