feat: Extend the model of Segment with additional properties (DEV-3505)
#3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
approved these changes
Apr 17, 2024
| owl:maxCardinality "1"^^xsd:nonNegativeInteger ] , | ||
| [ rdf:type owl:Restriction ; | ||
| owl:onProperty :hasDescription ; | ||
| owl:minCardinality "0"^^xsd:nonNegativeInteger ] , |
There was a problem hiding this comment.
question: A Segment may have more than one description?
I would have expected a single description to be optional.
There was a problem hiding this comment.
That was my first assumption too, but turns out that projects may want to be able to describe different aspects of a Segment as different descriptions. I'd have been happy either way, but this aligns with how EKWS modelled their Sequences, which I found reason enough to go that way.
…o-segment-in-knora-base
mpro7
approved these changes
Apr 17, 2024
looks like this is approved, so I can write documentation for it right away |
BalduinLandolt
deleted the
feature/dev-3505-add-additional-properties-to-segment-in-knora-base
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-3505
This PR adds a number of properties to
knora-base:Segmentin hopes that most projects will find their needs satisfied by this, rather than needing subclasses of Segment with custom properties.For all of them, mappings to popular external ontologies have been added, in hope that this will be a step towards making data more interoperable; furthermore this backs up the claim that this is supposed to be a reasonable set of properties for the concept of segments.
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?