-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove test data generation for system and admin (groups, project, users) (DEV-3523) #3203
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
===========================================
+ Coverage 13.22% 86.93% +73.70%
===========================================
Files 270 272 +2
Lines 22244 22220 -24
===========================================
+ Hits 2941 19316 +16375
+ Misses 19303 2904 -16399 ☔ View full report in Codecov by Sentry. |
Why? Is it because client test data is too big? Are the tests also not relevant on top of that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for removing these (and generally the client test data), but I'm curious on the selection: Why this particular part of the test data? Was there a concrete motivation for it? Or is it just intended as the first step of removing all the client test data?
See the meeting minutes in https://linear.app/dasch/issue/DEV-3520/dsp-api-remove-generation-of-test-data-for-js-lib We have identified this set of test data as not being used anymore. So there is not need to collect them anymore. |
That makes a lot of sense. Thanks for the clarification! |
Pull Request Checklist
Task Description/Number
Removes following folders from the client-test-data.zip:
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?