Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove test data generation for system and admin (groups, project, users) (DEV-3523) #3203

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 22, 2024

Pull Request Checklist

Task Description/Number

Removes following folders from the client-test-data.zip:

/system/health
/admin/groups
/admin/projects
/admin/users

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title chore: Remove test data generation for system and admin (groups, project, users) chore: Remove test data generation for system and admin (groups, project, users) (DEV-3523) Apr 22, 2024
Copy link

linear bot commented Apr 22, 2024

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (a622e4f) to head (79b505b).
Report is 28 commits behind head on main.

❗ Current head 79b505b differs from pull request most recent head 630a51d. Consider uploading reports for the commit 630a51d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3203       +/-   ##
===========================================
+ Coverage   13.22%   86.93%   +73.70%     
===========================================
  Files         270      272        +2     
  Lines       22244    22220       -24     
===========================================
+ Hits         2941    19316    +16375     
+ Misses      19303     2904    -16399     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers
Copy link
Contributor

siers commented Apr 22, 2024

Why? Is it because client test data is too big? Are the tests also not relevant on top of that?

Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for removing these (and generally the client test data), but I'm curious on the selection: Why this particular part of the test data? Was there a concrete motivation for it? Or is it just intended as the first step of removing all the client test data?

@seakayone
Copy link
Contributor Author

seakayone commented Apr 22, 2024

Why ?
Why this particular set?

See the meeting minutes in https://linear.app/dasch/issue/DEV-3520/dsp-api-remove-generation-of-test-data-for-js-lib

We have identified this set of test data as not being used anymore. So there is not need to collect them anymore.

@seakayone seakayone enabled auto-merge (squash) April 22, 2024 14:56
@BalduinLandolt
Copy link
Contributor

Why ?
Why this particular set?

See the meeting minutes in https://linear.app/dasch/issue/DEV-3520/dsp-api-remove-generation-of-test-data-for-js-lib

We have identified this set of test data as not being used anymore. So there is not need to collect them anymore.

That makes a lot of sense. Thanks for the clarification!

@seakayone seakayone merged commit fc85b24 into main Apr 22, 2024
11 checks passed
@seakayone seakayone deleted the chore/rm-admin-system-testdata-generation branch April 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants