Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove GroupsResponderADM (DEV-3292) #3213

Merged
merged 6 commits into from
Apr 25, 2024
Merged

refactor: Remove GroupsResponderADM (DEV-3292) #3213

merged 6 commits into from
Apr 25, 2024

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Apr 24, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@linear Linear
Copy link

linear bot commented Apr 24, 2024

DEV-3292 Remove the `GroupsResponder`

@mpro7 mpro7 changed the title improve multiple iris validation refactor: Remove GroupsResponderADM (DEV-3292) Apr 25, 2024
@mpro7 mpro7 marked this pull request as ready for review April 25, 2024 08:12
@mpro7 mpro7 self-assigned this Apr 25, 2024
@siers
Copy link
Contributor

siers commented Apr 25, 2024

Just dead code PR? Wonderful.

BalduinLandolt
BalduinLandolt approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mpro7
Copy link
Contributor Author

mpro7 commented Apr 25, 2024 •
edited
Loading

Just dead code PR? Wonderful.

Not really, there was still one method that needed to be replaced, but it released the dead code cleanup.

@mpro7 mpro7 enabled auto-merge (squash) April 25, 2024 09:34
@mpro7 mpro7 merged commit 8d2b5ba into main Apr 25, 2024
10 checks passed
@mpro7 mpro7 deleted the dev-3292-9 branch April 25, 2024 09:53
@daschbot daschbot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@siers siers siers approved these changes

@seakayone seakayone Awaiting requested review from seakayone seakayone is a code owner

Assignees

@mpro7 mpro7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpro7 @siers @BalduinLandolt