Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace spray with zio-json in admin endpoints #3220

Merged
merged 6 commits into from
Apr 30, 2024
Merged

refactor: Replace spray with zio-json in admin endpoints #3220

merged 6 commits into from
Apr 30, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 29, 2024 •
edited
Loading

  • Move project related models to admin api slice
  • Remove spray dependency from /admin/ api endpoints**

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone self-assigned this Apr 29, 2024
@seakayone seakayone marked this pull request as ready for review April 30, 2024 07:01
mpro7
mpro7 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seakayone seakayone mentioned this pull request Apr 30, 2024
Merged
12 tasks
@seakayone seakayone merged commit e38e3a7 into main Apr 30, 2024
11 checks passed
@seakayone seakayone deleted the refactor/replace-spray-with-zio-json branch April 30, 2024 12:12
@daschbot daschbot mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @mpro7