Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add prefix handling to admin permission repo #3290

Merged
merged 12 commits into from
Jun 19, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jun 18, 2024

  • Inline OntologyResponderV2 trait
  • Add test for administrative permissions
  • Add test for daop permissions
  • fix: Use knora-admin: prefix for storing permission hasPermissions string literal of AdministrativePermission

Fixes group iris to be using knora:admin prefix in hasPermission string literals. All other group iris will not be shortened with the prefix.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title fix/add prefix handling do admin permission repo fix: Add prefix handling to admin permission repo Jun 18, 2024
@siers
Copy link
Contributor

siers commented Jun 18, 2024

Please rebase it, it contains changes from the already merged code.

@seakayone seakayone merged commit 88e6b72 into main Jun 19, 2024
9 checks passed
@seakayone seakayone deleted the fix/add-prefix-handling-do-admin-permission-repo branch June 19, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants