Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix query tracking tags (== is faulty), set previous bucket sizes (DEV-3776) #3305

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Jul 4, 2024

Pull Request Checklist

Checked that the labels are now differentiated locally. The problem was == is really lax and just compares the object ids (or something). Cats' === would work, but then an Eq has to be derived and imported. The problem was .timeout wasn't added, so it was compared against an entirely different set of objects.

Second, now that the Grafana dashboard calculates the heatmaps correctly and bucket differences are pristine, I'm restoring the wide bucket range.

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Copy link

linear bot commented Jul 4, 2024

@siers siers marked this pull request as ready for review July 4, 2024 10:48
@siers siers merged commit 04b2a05 into main Jul 4, 2024
9 checks passed
@siers siers deleted the fix/fuseki-duration-bugs branch July 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants