Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add shortcode query param for GET /admin/lists #3369

Merged
merged 9 commits into from
Sep 19, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Sep 19, 2024

Pull Request Checklist

Task Description/Number

On GET /admin/lists provide either a projectIri or a projectShortcode.
Return a 404 if a project identifier was provided but the project not found.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone enabled auto-merge (squash) September 19, 2024 14:57
@seakayone seakayone merged commit 56733d2 into main Sep 19, 2024
8 checks passed
@seakayone seakayone deleted the feat/allow-shortcode-on-list-endpoint branch September 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants