Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add /shacl/validate endpoint (DEV-4149) #3371

Merged
merged 12 commits into from
Sep 27, 2024
Merged

feat: Add /shacl/validate endpoint (DEV-4149) #3371

merged 12 commits into from
Sep 27, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Sep 25, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title feat: Add /shacl/validate endpoint feat: Add /shacl/validate endpoint (DEV-4149) Sep 25, 2024
@linear Linear
Copy link

linear bot commented Sep 25, 2024

DEV-4149 install more performant SHACL validator

@seakayone seakayone marked this pull request as ready for review September 25, 2024 12:48
siers
siers approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of endpoint code, the validator and some tests for it. I'm not sure what it validates entirely and how SHACL works anymore, but the code is rather unoffensive, feel free to merge.

mpro7
mpro7 approved these changes Sep 27, 2024
View reviewed changes
project/Dependencies.scala
// see: https://github.com/TopQuadrant/shacl/pull/177
val JenaVersion = "4.10.0"
val Rdf4jVersion = "5.0.2"
val TopbraidShaclVersion = "1.4.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the reason to create version constant if it's used only once.
Also the compatibility comment is already added to scala-steward.conf which should be enough.

@seakayone seakayone merged commit e9f592e into main Sep 27, 2024
8 checks passed
@seakayone seakayone deleted the feat/add-shacl-validation-endpoint branch September 27, 2024 07:05
@daschbot daschbot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

@Nora-Olivia-Ammann Nora-Olivia-Ammann Awaiting requested review from Nora-Olivia-Ammann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @mpro7