feat: Enable compaction after project erasure, with feature flag (DEV-4162) #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siers
requested review from
BalduinLandolt,
mpro7 and
seakayone
as code owners
seakayone
reviewed
Oct 3, 2024
webapi/src/main/scala/org/knora/webapi/slice/admin/api/service/ProjectRestService.scala
Outdated
Show resolved
Hide resolved
siers
force-pushed
the
feat/DEV-4162-db-compact-after-project-erasure
branch
from
e0d3f2c to
088a303
Compare
siers
force-pushed
the
feat/DEV-4162-db-compact-after-project-erasure
branch
from
088a303 to
f43f04c
Compare
|
Tested locally partially. There's an exception when calling project erasure route locally, but it looks about right, so I'll test it on the testing environments. That same exception cannot be found in Grafana, fortunately or unfortunately. |
seakayone
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also requires some feature flag enabling code in ops-deploy, already in progress.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?