Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Convert watermark to RGB workspace (DEV-3299) #3387

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat: Convert watermark to RGB workspace (DEV-3299) #3387

merged 1 commit into from
Oct 11, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Oct 11, 2024 •
edited
Loading

Pull Request Checklist

Problem noticed after testing on dev.

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@linear Linear
Copy link

linear bot commented Oct 11, 2024

DEV-3299 Sipi should overlay the watermark by adhering to the aspect ratio

@siers siers merged commit 0459c60 into main Oct 11, 2024
10 checks passed
@siers siers deleted the feat/DEV-3299-watermark-to-rgb branch October 11, 2024 13:43
@daschbot daschbot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seakayone seakayone seakayone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siers @seakayone