Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow creation of unformatted TextValues with language tags (DEV-4234) #3394

Merged
merged 7 commits into from
Oct 21, 2024
Merged

fix: Allow creation of unformatted TextValues with language tags (DEV-4234) #3394

merged 7 commits into from
Oct 21, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Oct 18, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title fix fix: Allow creation of unformatted TextValues with language tags (DEV-4234) Oct 18, 2024
@linear Linear
Copy link

linear bot commented Oct 18, 2024

DEV-4234 API Ignores Language Tags for TextValues without Standoff

@seakayone seakayone marked this pull request as ready for review October 18, 2024 14:48
BalduinLandolt
BalduinLandolt approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@seakayone seakayone enabled auto-merge (squash) October 21, 2024 11:50
@seakayone seakayone merged commit 3b9a42e into main Oct 21, 2024
8 checks passed
@seakayone seakayone deleted the fix/text-value-with-language branch October 21, 2024 12:12
@daschbot daschbot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 mpro7 approved these changes

@siers siers Awaiting requested review from siers siers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @mpro7 @BalduinLandolt