Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support propert json-ld for update value endpoint (DEV-4325) #3418

Merged
merged 4 commits into from
Nov 11, 2024
Merged

feat: Support propert json-ld for update value endpoint (DEV-4325) #3418

merged 4 commits into from
Nov 11, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Nov 8, 2024 •
edited
Loading

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@seakayone seakayone changed the title add updateValueV2fromJsonLd to ApiComplexV2JsonLdRequestParser feat: Support propert json-ld for update value endpoint Nov 11, 2024
@seakayone seakayone changed the title feat: Support propert json-ld for update value endpoint feat: Support propert json-ld for update value endpoint (DEV-4325) Nov 11, 2024
@linear Linear
Copy link

linear bot commented Nov 11, 2024

DEV-4325 Updated values

@seakayone seakayone marked this pull request as ready for review November 11, 2024 07:48
mpro7
mpro7 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion below:

webapi/src/main/scala/org/knora/webapi/slice/common/ApiComplexV2JsonLdRequestParser.scala Show resolved Hide resolved
@seakayone seakayone merged commit 039dcb6 into main Nov 11, 2024
9 checks passed
@seakayone seakayone deleted the refactor/json-ld-for-update-value branch November 11, 2024 16:15
@daschbot daschbot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpro7 mpro7 mpro7 approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

@siers siers Awaiting requested review from siers siers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seakayone @mpro7