feat: Allow external iris for property and resource class when updating doap (DEV-4341)

[seakayone]

deprecated: Deprecate endpoints for updating a Default Access Permission in favor of newly introduces PUT /admin/permissions/doap/:permissionIri endpoint

Deprecated endpoints:

• PUT /admin/permissions/:permissionIri/resourceClass
• PUT /admin/permissions/:permissionIri/property
• PUT /admin/permissions/:permissionIri/group (deprecated only for DOAPs)
• PUT /admin/permissions/:permissionIri/hasPermission (deprecated only for DOAPs)

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

• build/chore: maintenance tasks (no production code change)
• docs: documentation changes (no production code change)
• feat: represents new features
• fix: represents bug fixes
• perf: performance improvements
• refactor: represents production code refactoring
• test: adding or refactoring tests (no production code change)
• deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

• Tests for the changes have been added
• Docs have been added / updated

Does this PR introduce a breaking change?

• Yes

[linear]

DEV-4286 DOAP for "foo:bar" property can be created - literally!

[linear]

DEV-4341 POST `admin/permissions/doap` returns internal class/prop IRI

[seakayone]

I have added a new endpoint PUT /admin/permissions/doap/:permissionIri which allows for updating an existing doap. This is deprecating existing endpoints as described above. I also updated the documentation.

Please have another review.

[jnussbaum]

Thanks for your efforts. I have just looked at the documentation. If you think there is a particular code region where I should look at, I would need some directions.

I don't know how our deprecation process looks like. Perhaps you need to inform the frontend team about it?

[jnussbaum]

Don't you like this comment? You have resolved it, but not changed the documentation.

[mpro7]

Forgot to ask. Should this PR be marked actually as deprecated instead of feat?

[codecov]

Codecov Report

Attention: Patch coverage is 3.36134% with 115 lines in your changes missing coverage. Please review.

Project coverage is 19.04%. Comparing base (6ebe8e7) to head (453d555).
Report is 134 commits behind head on main.

Files with missing lines	Patch %	Lines
...webapi/responders/admin/PermissionsResponder.scala	0.00%	56 Missing ⚠️
.../webapi/slice/admin/api/PermissionsEndpoints.scala	0.00%	30 Missing ⚠️
...main/model/DefaultObjectAccessPermissionRepo.scala	0.00%	10 Missing ⚠️
...lice/admin/api/service/PermissionRestService.scala	0.00%	9 Missing ⚠️
...a/webapi/slice/admin/domain/model/Permission.scala	50.00%	3 Missing ⚠️
...service/DefaultObjectAccessPermissionService.scala	0.00%	3 Missing ⚠️
...slice/admin/api/PermissionsEndpointsHandlers.scala	0.00%	2 Missing ⚠️
webapi/src/main/scala/dsp/errors/Errors.scala	0.00%	1 Missing ⚠️
...ebapi/slice/resourceinfo/domain/IriConverter.scala	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3425       +/-   ##
===========================================
- Coverage   83.04%   19.04%   -64.00%     
===========================================
  Files         290      308       +18     
  Lines       23087    22764      -323     
===========================================
- Hits        19172     4336    -14836     
- Misses       3915    18428    +14513     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[seakayone]

Forgot to ask. Should this PR be marked actually as deprecated instead of feat?

It is both, the deprecated notice in the description should show up in the release notes as well as far as I understand.