fix: Find the right doap when looking for by ForWhat #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakayone
requested review from
BalduinLandolt,
mpro7 and
siers
as code owners
seakayone
commented
Jan 16, 2025
| case Property(prop) => | ||
| pattern | ||
| .andHas(Vocabulary.KnoraAdmin.forProperty, Rdf.iri(prop.value)) | ||
| .filterNotExists(p.has(Vocabulary.KnoraAdmin.forResourceClass, variable("rc"))) |
There was a problem hiding this comment.
The filterNotExists prevents another ResourceClassAndProperty to match.
siers
approved these changes
Jan 17, 2025
mpro7
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This bug only surfaces when updating some dependencies.
Hence this needs to be merged before #3456
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?