fix: When changing the ontologies refresh the cache completely (DEV-4362)

[seakayone]

• inline OntologyTriplestoreHelpers trait
• inline OntologyCacheHelpers trait
• replace updating the Ontology manually with refreshing from DB
• remove after update checks

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

• build/chore: maintenance tasks (no production code change)
• docs: documentation changes (no production code change)
• feat: represents new features
• fix: represents bug fixes
• perf: performance improvements
• refactor: represents production code refactoring
• test: adding or refactoring tests (no production code change)
• deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

• Tests for the changes have been added
• Docs have been added / updated

Does this PR introduce a breaking change?

• Yes

[linear]

DEV-4362 cannot create LinkValue if 1-n cardinality is inherited from superclass

[BalduinLandolt]

Nice simplification!

Question: Are you confident that the extra work the API now has to do does not cause any significant performance regressions? Should we dedicate some time to test this specifically?

[BalduinLandolt]

praise: Nice to see so much deleted!

question: Do you think it would be worth adding a test to assert that any change to an ontology also triggers a cache reload?

[seakayone]

does not cause any significant performance regressions

The added overhead is refreshing the ontology cache, which is ~ .4 seconds or less. However, where this is added I removed the after update checks which my guess is take a similar amount of time. All in all I think the "performance" did not decrease significantly.

Do you think it would be worth adding a test to assert that any change to an ontology also triggers a cache reload?

No. Most of it should be covered with existing tests already.

[BalduinLandolt]

Grat, thanks!

[codecov]

Codecov Report

Attention: Patch coverage is 93.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.28%. Comparing base (6ebe8e7) to head (c4686c6).
Report is 180 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/main/scala/org/knora/webapi/core/AppServer.scala	40.00%	3 Missing ⚠️
...ora/webapi/responders/v2/OntologyResponderV2.scala	95.71%	3 Missing ⚠️
...nders/v2/ontology/OntologyTriplestoreHelpers.scala	93.75%	1 Missing ⚠️
...api/slice/admin/api/service/StoreRestService.scala	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3468      +/-   ##
==========================================
- Coverage   83.04%   82.28%   -0.77%     
==========================================
  Files         290      312      +22     
  Lines       23087    22576     -511     
==========================================
- Hits        19172    18576     -596     
- Misses       3915     4000      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.