Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new error handling strategy (DEV-1770) #324

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1770

@jnussbaum jnussbaum self-assigned this Mar 10, 2023
@linear
Copy link

linear bot commented Mar 10, 2023

DEV-1770 DSP-TOOLS: improve error handling

Currently, BaseError is the most frequently used error class, regardless if the error is handled by the calling method, or if it escalates, so that the user sees a stracktrace on the terminal.

It would be good to handle errors in two different ways:

  • BaseError for dsp-tools internal things that (should be) handled somewhere in the code. If they are not handled for some reason, they will escalate, and the user will see a stack trace on his terminal.
  • UserError for errors that escalate until the user sees them on the terminal. In this case, the stack trace should NOT be printed, and the error message should be as gentle/useful as possible, so that the user understands it and knows what to do.

@jnussbaum jnussbaum merged commit f2aa4b0 into main Mar 10, 2023
@jnussbaum jnussbaum deleted the wip/dev-1770-new-error-handling branch March 10, 2023 14:53
@daschbot daschbot mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants