Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin lists: createChildNode should send a httpPost request, not httpPut #1559

Closed
flavens opened this issue Dec 17, 2019 · 1 comment · Fixed by #1560
Closed

Admin lists: createChildNode should send a httpPost request, not httpPut #1559

flavens opened this issue Dec 17, 2019 · 1 comment · Fixed by #1560
Assignees
@benjamingeer
Labels
API/Admin bug something isn't working

Comments

@flavens
Copy link
Contributor

flavens commented Dec 17, 2019

In the method createChildNode() in the generated code of knora-api-js-lib, the API request is wrong: it is not httpPut() but httpPost().

method to update:

createChildNode(node: CreateChildNodeRequest): Observable<ApiResponseData<ListInfoResponse> | ApiResponseError> {
        return this.httpPut(.... ..... ....);
}

reference to #1509
@flavens flavens added bug something isn't working breaking/api API/Admin labels Dec 17, 2019
@flavens flavens mentioned this issue Dec 17, 2019
Merged
@benjamingeer benjamingeer mentioned this issue Dec 17, 2019
Merged
@benjamingeer
Copy link

Thank you for catching this! Please try PR #1560.

@benjamingeer benjamingeer added this to the 2020-01 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamingeer benjamingeer

Labels
API/Admin bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(clientapi): Fix HTTP method in createChildNode function dasch-swiss/dsp-api
2 participants
@benjamingeer @flavens